[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule #193420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
added
v8.16.0
backport:version
elastic-vault-github-plugin-prod
bot
requested a review
from a team
as a code owner
darnautov
reviewed
Sep 19, 2024
| @@ -131,7 +131,7 @@ paths: | |||
| type: string | |||
| required: | |||
| - note | |||
| description: 'The note to add or update, along with additional metadata.' | |||
There was a problem hiding this comment.
@rbrtj I wonder what triggered these changes?
There was a problem hiding this comment.
weird, these changes were merged in this PR already https://github.com/elastic/kibana/pull/191834/files?file-filters%5B%5D=.json&file-filters%5B%5D=.ts&file-filters%5B%5D=.tsx&file-filters%5B%5D=.yaml&owned-by%5B%5D=PhilippeOberti&show-viewed-files=true
There was a problem hiding this comment.
Honestly, I have no idea 🤔
But they are gone after updating the branch with the main
peteharverson
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @rbrtj |
rbrtj
added
backport:version
rbrtj
added
the
backport:prev-major
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
…ion rule (elastic#193420) ## Summary It was trying to parse `null` values. After:  Fixes [elastic#190732](elastic#190732) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 65b7bf9)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
…ion rule (elastic#193420) ## Summary It was trying to parse `null` values. After:  Fixes [elastic#190732](elastic#190732) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 65b7bf9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
weizijun
added a commit
to weizijun/kibana
that referenced
this pull request
Sep 23, 2024
* main: (176 commits) [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420) Bump maximum supported package spec version to 3.2 (elastic#193574) [ES|QL] new pattern for `SORT` autocomplete (elastic#193595) [Inventory][ECO] Entities page search bar (elastic#193546) [Synthetics] Remove extra overview route (elastic#192449) [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693) [Migrations] Remove tests that are not applicable in 9.x (elastic#193699) [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017) [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557) [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562) [Entity Analytics] Ensuring definition transforms are managed (elastic#193408) [Automatic Import] Do not remove message field for unstructured logs (elastic#193678) [Fleet] Add missing permissions for connector package (elastic#193573) [Fleet] using @kbn/config-schema part 2 (outputs and other apis) (elastic#193326) [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328) [ES|QL] Renames the textbased editor to esql editor (elastic#193521) [ES|QL] Update function metadata (elastic#193662) [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303) [Docs] Update Sharing docs (elastic#190318) [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243) ... # Conflicts: # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx # x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
…detection rule (#193420) (#193731) # Backport This will backport the following commits from `main` to `8.x`: - [[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)](#193420) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T14:27:01Z","message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:prev-major"],"title":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule","number":193420,"url":"https://github.com/elastic/kibana/pull/193420","mergeCommit":{"message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193420","number":193420,"mergeCommit":{"message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
… detection rule (#193420) (#193730) # Backport This will backport the following commits from `main` to `8.15`: - [[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)](#193420) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T14:27:01Z","message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:prev-major"],"title":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule","number":193420,"url":"https://github.com/elastic/kibana/pull/193420","mergeCommit":{"message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193420","number":193420,"mergeCommit":{"message":"[ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (#193420)\n\n## Summary\r\n\r\nIt was trying to parse `null` values.\r\nAfter:\r\n\r\n\r\n\r\nFixes [#190732](https://github.com/elastic/kibana/issues/190732)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"65b7bf9586480b522393905ff21324f473ee90ed"}}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was trying to parse
nullvalues.After:
Fixes #190732